Skip to content

NPC Improvements

Jesusalva Jesusalva requested to merge npc-improvements into master

This Merge Request complies with the Terms Of Service, regardless if this notice is kept on the MR or not.

You're about to submit a Merge Request to the Server Data Team. Before proceeding, ensure to set the correct labels.

  • Status:Discussion if it is not yet ready for review.
  • Status:Incomplete if you are open to review but still has stuff to fix, properly documented on the MR.
  • Status:Complete if it is ready in your opinion. This is an explicit request for reviews.

In any of these three stats, any reviewer may pick up your MR, address anything missing, issue approval and commit it. Therefore, prefix the title with "WIP" or "Draft" if it is absolutely not yet ready for merging.

If you're not from the core team, please refrain from using Priority labels, unless you're addressing an issue which also had a priority label. In this case, make sure to mention the issue in the description.

Also make sure that:

  • If you used an upstream branch, it is marked to be deleted
  • If you dismarked the squash commit option, all commits are sane.
  • You'll deal with the bugs you're introducing.
  • And you've added at least one of the Status labels. Specially, the Status:Complete, as these take precedence for reviewers time.

In all cases, you'll need at least one developer or maintainer besides yourself to approve (code is sane and function is desired), in order to be merged. Maintainers are exempt from approval gathering if they merge to master directly; But their MRs follow the same rule outlined above.

Thanks for contributing!

Merge request reports