Skip to content

Fix unable to pickup non-ignored items while standing on an ignored item

Fedja Beader requested to merge specing/manaplus:pickupfix into master

What happened:

  1. The pickup code first tries to pickup first item under you without checking if it is ignored.
  2. ::pickUp queries ratelimiter, which clears to send.
  3. ::pickUp checks if item is ignored and bails out
  4. The pickup code did not bail early, despite "success" of (1) and selects a non-ignored item to pick-up.
  5. ::pickUp queries ratelimiter, which thinks that a packet has been sent in (2) and aborts.

Merge request reports