Skip to content

Fix daily quest point gain for characters with bonus points

Fedja Beader requested to merge specing/classic-serverdata:daily_bonus into master

Consider this MR for now as demonstrating the issue: When a character checks in with a daily point NPC, the bonus daily points (from boss fights) gets moved into the regular bonus variable. By my understanding, when this regular bonus variable exceeds the character's level, the character stops gaining regular daily points:

[18:35:42] Daily Points: You currently have 2 base and 0 bonus Daily Points, for a total of 2 Daily Points.
[18:35:48] Daily Points: You currently have 2 base and 0 bonus Daily Points, for a total of 2 Daily Points.
[18:40:10] variable DailyQuestPoints[0] == `2` for player RagerArcher.
[18:40:20] variable DailyQuestBonus[0] == `0` for player RagerArcher.
[18:41:25] variable DailyQuestBonus[0] = `3` for player RagerArcher.
[18:41:28] Daily Points: You currently have 2 base and 3 bonus Daily Points, for a total of 5 Daily Points.
After talking to arkim about giving him wings (I had none in inventory):
[18:41:40] Daily Points: You currently have 6 base and 0 bonus Daily Points, for a total of 6 Daily Points.

As you can see, when DailyQuestPoints exceeeds player lvl (134), the player no longer gets any (DailyQuestTime marks the last time the base points were added):

[22:10:36] Daily Points: You currently have 6 base and 3 bonus Daily Points, for a total of 9 Daily Points.
[22:11:17] variable DailyQuestTime[0] == `1712255997` for player RagerArcher.
[22:11:36] variable DailyQuestTime[0] = `0` for player RagerArcher.
[22:11:44] Daily Points: You currently have 6 base and 3 bonus Daily Points, for a total of 9 Daily Points.
[22:11:52] Daily Points: You currently have 137 base and 0 bonus Daily Points, for a total of 137 Daily Points.
[22:12:21] variable DailyQuestBonus[0] = `50` for player RagerArcher.
[22:12:24] RagerArcher: .@setvar DailyQuestBonus 0 50 RagerArcher
[22:12:26] Daily Points: You currently have 137 base and 50 bonus Daily Points, for a total of 187 Daily Points.
[22:12:34] RagerArcher: (talk to arkim)
[22:12:41] Daily Points: You currently have 187 base and 0 bonus Daily Points, for a total of 187 Daily Points.
[22:12:53] variable DailyQuestTime[0] = `0` for player RagerArcher.
[22:12:54] RagerArcher: .@setvar DailyQuestTime 0 0 RagerArcher
[22:13:00] Daily Points: You currently have 187 base and 0 bonus Daily Points, for a total of 187 Daily Points.
[22:13:16] Daily Points: You currently have 187 base and 0 bonus Daily Points, for a total of 187 Daily Points.
[22:13:23] RagerArcher: (^talk to arkim)

I would also like to open a discussion here about how to improve dailies, with my suggestions being:

  • Make @dailypoint aka @dailypoints provide info about both the raw daily points and the bonus ones.
  • Add @dp shortcut (+@bp for boss points?) !735 (merged)
  • Fix daily bonus so it no longer gets dumped into DailyQuestPoints
  • Provide an option to people to only submit the daily part
Edited by Fedja Beader

Merge request reports